Feat/calculate nrd#34
Merged
Merged
Conversation
leavauchier
requested changes
Jul 1, 2026
leavauchier
left a comment
leavauchier
left a comment
Member
There was a problem hiding this comment.
J'ai oublié pour les dernières MR mais il manque le changelog
| np.testing.assert_array_equal(ni, np.zeros(60, dtype=ni.dtype)) | ||
| np.testing.assert_array_equal(n_per_stratum, np.full(60, n, dtype=n_per_stratum.dtype)) | ||
| # ni=0, n=5 for every stratum -> NRD=0 -> Laplace correction: (0+1)/(5+2) = 1/7 | ||
| np.testing.assert_allclose(nrd, np.full(60, 1 / 7)) |
Member
There was a problem hiding this comment.
c'est un allclose volontaire cette fois-ci ?
Collaborator
Author
There was a problem hiding this comment.
oui : pour calculer (0+1)/(5+2) en flottant.
- si je mets "assert_array_equal", cela échouerait à cause de l'arrondi.
- si je mets "assert_allclose", cela n'échouerait pas
leavauchier
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Etape 4. Calculer la fractions des rayons entrants qui on été interceptés pour chaque strate "NRD"
https://github.com/orgs/IGNF/projects/32/views/17?pane=issue&itemId=181841417&issue=IGNF%7ClidarHD_process%7C459